virtIO: Fail gracefully when unable to push descriptor to wirtqueue message#2163
Open
francescolavra wants to merge 1 commit into
Open
virtIO: Fail gracefully when unable to push descriptor to wirtqueue message#2163francescolavra wants to merge 1 commit into
francescolavra wants to merge 1 commit into
Conversation
…essage To gracefully handle out-of-memory conditions, change vqmsg_push() to return a boolean value indicating whether it successfully added the descriptor to the virtqueue message. To avoid the need for callers to always check the return value from vqmsg_push(), add a new parameter to allocate_vqmsg() to specify the number of descriptors that is guaranteed to be available, i.e. the number of subsequent calls to vqmsg_push() that are guaranteed to return a success value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To gracefully handle out-of-memory conditions, change vqmsg_push() to return a boolean value indicating whether it successfully added the descriptor to the virtqueue message. To avoid the need for callers to always check the return value from vqmsg_push(), add a new parameter to allocate_vqmsg() to specify the number of descriptors that is guaranteed to be available, i.e. the number of subsequent calls to vqmsg_push() that are guaranteed to return a success value.
This fix prevents assertion failures such as in #2133.